Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dom-repeat has some issues in stamping when it is distributed content in ShadyDOM #3919

Closed
kevinpschaaf opened this issue Sep 9, 2016 · 3 comments
Assignees

Comments

@kevinpschaaf
Copy link
Member

From @valdrinkoshi on August 19, 2016 0:51

In ShadyDOM mode, dom-repeat has some issues in stamping when it is distributed content, e.g.

<!-- x-outer template -->
    <template>
      <x-inner>
        <slot></slot>
      </x-inner>
    </template>

<!-- dom-repeat in x-outer -->
  <x-outer>
    <dom-repeat items='[{"name": "item0"}]'>
      <template>
        <div id$="[[item.name]]">{{item.name}}</div>
      </template>
    </dom-repeat>
  </x-outer>

http://jsbin.com/jadedag/2/edit?html,console,output

Copied from original issue: PolymerLabs/alacarte#73

@kevinpschaaf
Copy link
Member Author

From @sorvell on August 22, 2016 17:2

The issue here is that the dom-repeat is getting patched by x-outer when it creates its shadowRoot and then un-patched when it upgrades. Since dom-repeat does not create a shadowRoot (the only way an element kicks off patching currently), it never gets re-patched.

This problem is similar to #62. Both of these issues are suggesting that the mechanism via which an element is patched is going to need some work.

@sorvell sorvell self-assigned this Sep 9, 2016
@sorvell
Copy link
Contributor

sorvell commented Sep 9, 2016

Will be addressed via webcomponents/shadydom#7.

@sorvell
Copy link
Contributor

sorvell commented Feb 24, 2017

No longer relevant.

@sorvell sorvell closed this as completed Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants