Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer 2.0 preview Issue - Computed Bindings stopped working with this commit #4354

Closed
1 task done
marybeshaw opened this issue Mar 1, 2017 · 3 comments
Closed
1 task done

Comments

@marybeshaw
Copy link

Description

I updated my polymer 2.0 preview installation, and computed bindings as well as individual observers stopped working.

Computed binding (such as _getContainerClasses below) is not called:

<div class$="[[_getContainerClasses(centered)]]"></div>

Individual Observer function such as (observerFunction below) is not called:

      static get config() {
        return {
          properties: {
            property: {
              type: "String",
              value: "[]",
              observer: "observerFunction"
            }
          }
        }
      }

Live Demo

Spinner element (which uses a computed binding; I simplified it for sharing):
http://jsbin.com/bafide/1/edit?html,output

Unit test for spinner element:
http://jsbin.com/qunuge/1/edit?html,output

Steps to Reproduce

When I pin to commit Polymer/polymer#5c1b11ff0f0b96665f40179e53f2d21a955ef605, unit tests in the second jsbin work.
When I pin to commit Polymer/polymer#38fa1f6b09d03f53115b741a8ce0c27b8bd84f30, the same unit tests do not work.

Expected Results

When I update my installation of #2.0-preview, computed bindings (and individual observers) should work.

Actual Results

When I update my installation of #2.0-preview, computed bindings (and individual observers) DO NOT work.

Browsers Affected

  • Chrome

Versions

  • Polymer: v2.0-preview
  • webcomponents: v1
@miztroh-zz
Copy link

config has been replaced with properties and observers. See the updated README.

@LiberQuack
Copy link

Thks @miztroh

@marybeshaw
Copy link
Author

Thanks for the information. I missed that update somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants