Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency between core-iconset and core-icon bower modules #992

Closed
awk opened this issue Dec 3, 2014 · 2 comments
Closed

Circular dependency between core-iconset and core-icon bower modules #992

awk opened this issue Dec 3, 2014 · 2 comments

Comments

@awk
Copy link

awk commented Dec 3, 2014

bower.json for core-icon says :

"dependencies": {
"core-iconset": "Polymer/core-iconset#^0.5.0",
"core-icons": "Polymer/core-icons#^0.5.0"
},

bower.son for core-iconset says :

"dependencies": {
"polymer": "Polymer/polymer#^0.5.0",
"core-meta": "Polymer/core-meta#^0.5.0",
"core-icon": "Polymer/core-icon#^0.5.0"
},

The grunt bower-concat tool complains that there's a circular dependency between these modules. (Note I'm not using bower-concat for anything polymer related but it looks to be checking the entire modules list I have).

@ebidel
Copy link
Contributor

ebidel commented Dec 3, 2014

Bower handles circular dependencies fine and fixed this a while back. I'm not familiar with bower-concat, but it seems like a problem with that tool. Can you file this over there?

@awk
Copy link
Author

awk commented Dec 3, 2014

Thanks for the quick response.

Yep - this really looks to be just an issue with grunt-bower-concat. I created sapegin/grunt-bower-concat#38

@awk awk closed this as completed Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants