-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make exclusion similar to r.js #1697
Comments
Seems like we need a flag (e.g. |
@ebidel I think that's captured on this ticket: https://github.com/Polymer/vulcanize/issues/66 Specifically I'm asking if we can do away with the regex in ex:
In the above example, let's say I'm creating a file called |
Great, I agree with this approach. Actually I'm developing a new tool for modular vulcanize. :) :( Anyway If we could make a bundled it that I can use the bundle like as a static library in native environments. In my use case, that is development Chrome apps: after bower install, I bundled polymer and installed any web-components to polymer-cores.html, polymer-papers.html and 3rd-party-components.html, then I import them to my custom component and I write a my custom component html with external scripts. I don't have to do 'vulcanzie --csp` every time for a while development chrome apps and have more benefit . |
We could improve config file to supports more options that can be similar to Makefile. see below.
In first step, Vulcanize would create a component.html which has shared imports. other custom-elements in app could be imported the 'component.html'. and it should be supported multiple vulcanize execution with various options. |
This approach would require that vulcanize keep some sort of metadata about what each vulcanized bundle contains. That information is not stored anywhere currently. Where should that metadata go? It can either be in the output file as a special comment, or as a separate file. |
Vulcanize 1.x exclusion includes transitive dependencies via hydrolysis. |
:) now I am running into an issue which I guess you guys have envisioned earlier. |
In r.js when you're creating module bundles you can tell one bundle to exclude everything that's in another bundle. Here's an example. I'm creating 3 bundles (
common
,main-about
,main-contact
). Instead of having to manually go through everything incommon
to find all of the dependencies and exclude each as a regex, I can just tell themain-about
andmain-contact
bundles to exclude all of the modules incommon
. This makes it very easy to lazy load AMD bundled modules and I think imports could use a similar approach.The text was updated successfully, but these errors were encountered: