Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-drawer-layout: Unable to get the latest code from master using bower install --save PolymerElements/app-layout #231

Closed
8 tasks done
cherukumilli opened this issue Jun 5, 2016 · 2 comments

Comments

@cherukumilli
Copy link

Description

app-drawer-layout: Unable to get the latest code from master using bower install --save PolymerElements/app-layout

Expected outcome

bower install --save PolymerElements\app-layout is pulling app-drawer-layout code with _narrow hidden property instead of narrow property
Code fixed in #217 is not getting installed.

      properties: {
        /**
         * If true, ignore `responsiveWidth` setting and force the narrow layout.
         */
        forceNarrow: {
          type: Boolean,
          value: false
        },
        /**
         * If the viewport's width is smaller than this value, the panel will change to narrow
         * layout. In the mode the drawer will be closed.
         */
        responsiveWidth: {
          type: String,
          value: '640px'
        },
        /**
         * Returns true if it is in narrow layout. This is useful if you need to show/hide
         * elements based on the layout.
         */
        narrow: {
          type: Boolean,
          readOnly: true,
          notify: true
        }
      },

Actual outcome

      properties: {
        /**
         * If true, ignore `responsiveWidth` setting and force the narrow layout.
         */
        forceNarrow: {
          type: Boolean,
          value: false
        },

        /**
         * If the viewport's width is smaller than this value, the panel will change to narrow layout.
         * In the mode the drawer will be closed.
         */
        responsiveWidth: {
          type: String,
          value: '640px'
        },

        _narrow: Boolean
      },

Live Demo

Good in the master branch below is not getting installed using bower install --save PolymerElements\app-layout
https://github.com/PolymerElements/app-layout/blob/master/app-drawer-layout/app-drawer-layout.html

Steps to reproduce

  1. Go to the terminal window
  2. Go to your project folder
  3. Enter bower install --save PolymerElements/app-layout
  4. Open file bower_components/app-layout/app-drawer-layout/app-drawer-layout.html

Browsers Affected

  • Chrome
  • Firefox
  • Safari 9
  • Safari 8
  • Safari 7
  • Edge
  • IE 11
  • IE 10
@cherukumilli
Copy link
Author

@keanulee
Can you please take a look at this problem?
does the archive need an update?

@frankiefu
Copy link
Contributor

We haven't tagged a new release yet, will probably do one soon like this week. In the meantime you can get the latest from master using #master, e.g.
bower install PolymerElements/app-layout#master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants