Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

finish typings for iron-overlay-behavior managers #262

Open
aomarks opened this issue Feb 7, 2018 · 0 comments
Open

finish typings for iron-overlay-behavior managers #262

aomarks opened this issue Feb 7, 2018 · 0 comments

Comments

@aomarks
Copy link
Contributor

aomarks commented Feb 7, 2018

  • IronScrollManager is missing currentLockingElement, because it is a getter, and the Analyzer namespace scanner does not handle getters. We can either fix https://github.com/Polymer/polymer-analyzer/issues/866, or use the addReferences setting in gen-tsd.json to augment the namespace with a manually written version. Augmenting will also require fixing https://github.com/Polymer/gen-typescript-declarations/issues/86, however, because otherwise the manually written file will get deleted every time the typings are re-generated.

  • IronOverlayManager is a singleton instance of a class. The class itself is @private. Also the class is created by directly writing to .prototype, which Analyzer doesn't really understand (at least not without a lot of annotations). For this, we probably just want to manually write all of the typings and add them with addReferences.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant