Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VScode client broken #4039

Open
Cypher1 opened this issue Nov 8, 2019 · 0 comments
Open

VScode client broken #4039

Cypher1 opened this issue Nov 8, 2019 · 0 comments
Assignees
Labels
bug A problem known to be a bug is slated for squashing. p2 Fix if there are no higher priority issues, or as part of Sheriff duties.

Comments

@Cypher1
Copy link
Contributor

Cypher1 commented Nov 8, 2019

The normal set up steps.

sigh languageServer --install
npm install:vscodeclient

Do not work, tracking this down, I have found that tsc fails to compile the package with:

node_modules/@types/node/index.d.ts:170:11 - error TS2300: Duplicate identifier 'IteratorResult'.

This leads to the following TS issue:
microsoft/TypeScript#32333

Which suggests upgrading packages, there also seem to be other packages missing from the client's node_modules directory. I will investigate further.

In future, I'd like to avoid this kind of breakage by having the language server and client built and tested on Travis. I plan to look into doing this without increasing the travis build times (e.g. by installing vscode).

@Cypher1 Cypher1 added the bug A problem known to be a bug is slated for squashing. label Nov 8, 2019
@Cypher1 Cypher1 self-assigned this Nov 8, 2019
@shaper shaper added the p2 Fix if there are no higher priority issues, or as part of Sheriff duties. label Nov 14, 2019
@Cypher1 Cypher1 assigned alxmrs and unassigned Cypher1 Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem known to be a bug is slated for squashing. p2 Fix if there are no higher priority issues, or as part of Sheriff duties.
Projects
None yet
Development

No branches or pull requests

3 participants