Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Automerge doesn't appear for incoming pull requests #535

Open
dstoc opened this issue May 17, 2018 · 7 comments
Open

Automerge doesn't appear for incoming pull requests #535

dstoc opened this issue May 17, 2018 · 7 comments

Comments

@dstoc
Copy link

dstoc commented May 17, 2018

Expected Behavior

After I approve an incoming pull request I should be able to set the auto-merge option from project-health.

@samuelli
Copy link
Contributor

Are there any restrictions? Sample restrictions:

  • You must have merge abilities
  • PR author doesn't have merge abilities

@dstoc
Copy link
Author

dstoc commented May 18, 2018

  • PR author doesn't have merge abilities

Not sure about that one. That seems a case where the reviewer would be required to merge it.

@samuelli
Copy link
Contributor

Right, but if they did have merge abilities, should you also see the auto-merge option? If you did, then both of you could have the auto merge option available for the same PR.

@dstoc
Copy link
Author

dstoc commented May 21, 2018

Right, but if they did have merge abilities, should you also see the auto-merge option? If you did, then both of you could have the auto merge option available for the same PR.

Yes. I often merge other project member's PRs -- when we're operating in different timezones it results in changes landing much faster.

@dstoc
Copy link
Author

dstoc commented May 21, 2018

If you did, then both of you could have the auto merge option available for the same PR.

If both author + reviewer use automerge, that seems OK -- doesn't really matter too much which one goes ahead.

@samuelli
Copy link
Contributor

samuelli commented Jun 1, 2018

If both author + reviewer use automerge, that seems OK -- doesn't really matter too much which one goes ahead.

You could have contention over what method to use though.

@gauntface: how possible do you think this is? I'm not sure how the auto merge stuff is stored rn.

@gauntface
Copy link
Contributor

Steps for adding this would be:

1.) Figure out when to show the UI for automerge to the reviewer.
2.) Store the automerge option in the backend (this is done against the PR itself, so would sync between reviewer and PR author).
3.) The automerge should just work from this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants