Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instruction dates #1397

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Fix instruction dates #1397

merged 3 commits into from
Dec 4, 2024

Conversation

polymath-eric
Copy link
Collaborator

Description

Make Instruction tradeDate and valueDate Date type when fetching from middleware

Breaking Changes

JIRA Link

Checklist

  • Updated the Readme.md (if required) ?

@polymath-eric polymath-eric requested a review from a team as a code owner December 4, 2024 17:53
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@polymath-eric
Copy link
Collaborator Author

/fast-forward

@prashantasdeveloper prashantasdeveloper merged commit 5348f85 into beta Dec 4, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVicente VictorVicente VictorVicente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@polymath-eric @VictorVicente @prashantasdeveloper @F-OBrien