Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 handle tradeDate and valueDate of null in instruction details #1402

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

F-OBrien
Copy link
Collaborator

@F-OBrien F-OBrien commented Dec 5, 2024

Description

Breaking Changes

JIRA Link

Checklist

  • Updated the Readme.md (if required) ?

@F-OBrien F-OBrien requested a review from a team as a code owner December 5, 2024 17:10
@F-OBrien F-OBrien changed the base branch from master to alpha December 5, 2024 17:13
Copy link
Collaborator

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking into the code coverage. The change looks OK though, but should have a test case for the coverage metric

Copy link

sonarcloud bot commented Dec 5, 2024

@polymath-eric
Copy link
Collaborator

/fast-forward

@prashantasdeveloper prashantasdeveloper merged commit 4c20be3 into alpha Dec 5, 2024
13 checks passed
@prashantasdeveloper prashantasdeveloper deleted the fix/mw-dates2 branch December 5, 2024 17:34
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 27.0.2-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 27.0.2-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 27.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants