fix: 🐛 handle createdAt order by for SQ v19+ #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix offChainAffirmations, instructionAffirmations order by. Handle CREATED_AT order by in getTransactionHistory, getHeldAssets and getHeldNfts by replacing it with CREATED_BLOCK_ID order instead (which is equivalent in SQv19+). Created at ordering is marked as deprecated and will be removed when SQ v18 is no longer supported
F-OBrien
reviewed
Dec 7, 2024
There was a problem hiding this comment.
I can't view the middleware type on github but the deprecation notes for NftHoldersOrderBy and AssetHoldersOrderBy should read
/**
* @deprecated - Removed in SQ v19 updates `CreatedBlockIdAsc` to work instead
*/
CreatedAtAsc = 'CREATED_AT_ASC',
/**
* @deprecated - Removed in SQ v19 updates `CreatedBlockIdDesc` to work instead
*/
CreatedAtDesc = 'CREATED_AT_DESC',
not BlockIdAsc and BlockIdDesc
VictorVicente
previously approved these changes
Dec 9, 2024
Update deprecated notices to include "Created" where needed, e.g. `BlockIdDesc` -> `CreatedBlockIdDesc`
|
VictorVicente
approved these changes
Dec 9, 2024
|
/fast-forward |
|
🎉 This PR is included in version 27.0.3-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 27.1.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 27.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix offChainAffirmations, instructionAffirmations order by. Handle CREATED_AT order by in getTransactionHistory, getHeldAssets and getHeldNfts by replacing it with CREATED_BLOCK_ID order instead (which is equivalent in SQv19+). Created at ordering is marked as deprecated and will be removed when SQ v18 is no longer supported
Breaking Changes
Using
CREATED_AT_{ASC|DESC}is now deprecated. SQ v19+ will order correctly using Block ID insteadJIRA Link
DA-1434
Checklist