Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 update SQ v19 support for the latest changes #1411

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

polymath-eric
Copy link
Collaborator

Description

instruction and authorization IDs are no longer padded. Queries are updated accordingly

Breaking Changes

JIRA Link

Checklist

  • Updated the Readme.md (if required) ?

@polymath-eric polymath-eric requested a review from a team as a code owner December 11, 2024 19:06
F-OBrien
F-OBrien previously approved these changes Dec 11, 2024
Copy link
Collaborator

@F-OBrien F-OBrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comments

src/middleware/queries/authorizations.ts Outdated Show resolved Hide resolved
src/middleware/queries/settlements.ts Outdated Show resolved Hide resolved
instruction and authorization IDs are no longer padded. Queries are
updated accordingly
@polymath-eric
Copy link
Collaborator Author

For transparency, I manually added the CREATED_EVENT_ID field directly into the middleware types file.

Typegen with v19 wipes all of the deprecated fields which are more numerous to add in/work around.

Copy link

sonarcloud bot commented Dec 11, 2024

@polymath-eric
Copy link
Collaborator Author

/fast-forward

@prashantasdeveloper prashantasdeveloper merged commit 669871f into alpha Dec 11, 2024
12 checks passed
@prashantasdeveloper prashantasdeveloper deleted the update-sq-19-support branch December 11, 2024 20:02
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 27.1.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants