Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect location of engine mount points on Kerbodyne Engine Cluster Adapter Tank #997

Closed
Alex-1248 opened this issue Nov 12, 2022 · 6 comments
Assignees
Labels
art bug bug pertains to art making history content related to making history restock base content is base restock restock+ content is part of restock+

Comments

@Alex-1248
Copy link

If Restock is installed, the engine mount points on the Kerbodyne Engine Cluster Adapter Tank from Making History are not symmetrical in all variants. The center of thrust does not coincide with the center of mass and a symmetrical rocket cannot fly straight without the help of SAS. The problem also occurs if Restock+ is installed and Making History is not installed.

@Poodmund
Copy link
Collaborator

Yeah I can see that the node attach transforms in the .mu are not evenly spaced around the origin which would result in thrust torque.

This fix would require work within the model itself and a re-export.

@Poodmund Poodmund added restock base content is base restock restock+ content is part of restock+ art bug bug pertains to art making history content related to making history labels Nov 12, 2022
@Poodmund
Copy link
Collaborator

Poodmund commented May 19, 2024

Putting in here for future reference, the coordinate location values for the node transforms need to be as follows:

N2/N4 attach node setup: (1.76777, 1.76777)
N3/N6 attach node setup: (1.3, 2.5) & (2.16506, 1.25)

@Poodmund Poodmund self-assigned this May 25, 2024
@Poodmund
Copy link
Collaborator

@Alex-1248, I attempted to fix the .mu model by relocating the engine node transforms to the correct positions but upon export using Taniwha's .mu Import/Export plugin it was causing the file size to balloon to over twice the size... so I came up with a great temporary solution without needing the original source file, I've created a new .mu that ONLY contains the engine node transforms and edited the part config file to also load this .mu into the part, and subsequently switched all the engine node transform references over to the additional .mu.

You can see the changes here: dd2bbad

Can you download the new .mu and updated config and give it a test? I loaded it in alongside Kerbal Engineer Redux and also RCS Build Aid and it appeared to resolve the issue and reduce thrust torque to near-zero (I expect floating point error induces extremely slight transform differences).

@Alex-1248
Copy link
Author

I tested it.

The problem no longer appears if Making History is installed.

But the problem still appears if Making History is not installed and Restock+ is installed.

@Poodmund
Copy link
Collaborator

Thank you for confirming (after all this time 😅), I did push an additional commit to cover RS+ but will go back and test it.

@Poodmund
Copy link
Collaborator

Just checked myself, all sorted with MH not installed using the RS+ version with this commit: d0aabec

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
art bug bug pertains to art making history content related to making history restock base content is base restock restock+ content is part of restock+
Projects
Status: Done
Development

No branches or pull requests

2 participants