Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require clipping for dithering sample conversion functions? #112

Open
PortAudio-admin opened this issue Feb 1, 2011 · 3 comments
Open
Labels
LIST-REVIEW Requires open review/discussion on the mailing list P2 Priority: High src-common Common sources in /src/common
Milestone

Comments

@PortAudio-admin
Copy link
Collaborator

Issue created by @RossBencina

Consider whether functions which dither but don't clip should exist, V18 automatically enabled clipping whenever dithering was selected. Perhaps we should do the same.

This would have the advantage that it would eliminate many of the unimplemented converters in ticket #35

@PortAudio-admin
Copy link
Collaborator Author

Comment by @RossBencina

Related to:

#35 -- some conversion functions are not implemented in pa_converters.c

@PortAudio-admin
Copy link
Collaborator Author

Comment by @RossBencina

TRAC migration: propagating ticket status from TRAC

@PortAudio-admin PortAudio-admin added P2 Priority: High src-common Common sources in /src/common LIST-REVIEW Requires open review/discussion on the mailing list labels Sep 24, 2020
@PortAudio-admin PortAudio-admin added this to the V19 milestone Sep 24, 2020
@philburk
Copy link
Collaborator

If we dither then that could cause valid in-range data passed by the app to go out-of-range.
So, yes, I think if we dither then we should always clip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LIST-REVIEW Requires open review/discussion on the mailing list P2 Priority: High src-common Common sources in /src/common
Projects
None yet
Development

No branches or pull requests

2 participants