Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device_type on iOS isn't changeable - should it be? #49

Closed
marandaneto opened this issue Sep 25, 2023 · 3 comments
Closed

device_type on iOS isn't changeable - should it be? #49

marandaneto opened this issue Sep 25, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation iOS question Further information is requested

Comments

@marandaneto
Copy link
Member

marandaneto commented Sep 25, 2023 •
edited
Loading

https://github.com/PostHog/posthog-ios/blob/d3eeb3b60bd54b5cb87299c40378118e642a4474/PostHog/Internal/PHGPostHogIntegration.m#L145

Questions:

  • should device_type be changeable?
  • should device_type be mobile by default?
  • is the device_type -> android for Android? I have not found any references to this field on this SDK and on the Android SDK, so apparently this field isn't set at all (checked the latest version).

Docs:
https://posthog.com/docs/product-analytics/autocapture#autocaptured-properties
https://posthog.com/docs/product-analytics/user-properties

single source of truth: https://github.com/PostHog/posthog/blob/master/frontend/src/lib/taxonomy.tsx
Ticket
@marandaneto marandaneto added iOS bug Something isn't working documentation Improvements or additions to documentation question Further information is requested and removed bug Something isn't working labels Sep 25, 2023
@marandaneto
Copy link
Member Author

Similar to PostHog/posthog-ios#63

@marandaneto marandaneto mentioned this issue Sep 29, 2023
Merged
@marandaneto
Copy link
Member Author

marandaneto commented Oct 5, 2023 •
edited
Loading

We should follow the convention, we'll merge the PR to align on iOS.
The new Android SDK already sets it to Mobile as well.
There are other fields to filter per Android/iOS, such as $os_name

@marandaneto
Copy link
Member Author

https://github.com/PostHog/posthog-ios/releases/tag/2.0.5 updates the device_type to `Mobile.
Just upgrade your cocoapods dependencies.

@marandaneto marandaneto mentioned this issue Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation iOS question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marandaneto