Incorrect types on personProperties for getAllFlags

[xmonkee]

Bug description

personProperties is typed as Record<string, string> whereas it should be Record<string, string | number>

How to reproduce

Try to call getAllFlags with a numerical personProperty and you will get a type error

Related sub-libraries

• All of them
• posthog-web
• posthog-node
• posthog-react-native

Additional context

posthog-node version 3.6.3

[marandaneto]

The JS SDK is defined as:

export type Property = any
export type Properties = Record<string, Property>

@neilkakkar should it be similar to the JS SDK or was it intended to be <string, string>?

[neilkakkar]

oh I seem to have overlooked this. We can & should accept numbers too indeed 👍

[marandaneto]

oh I seem to have overlooked this. We can & should accept numbers too indeed 👍

@neilkakkar would you like/do you have time to take a stab at it before we release the next major? not sure if this is a breaking change, since Record<string, Property> will still be compatible with <string, string>.

[neilkakkar]

sigh want to but don't seem like I have the time with all the incident fixes :/

[neilkakkar]

Yeah wouldn't be breaking, will relax types in all functions