-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GeoIP handling for server side & client side events more seamless #14351
Comments
In case I'm not misunderstanding....
So, we can already instruct to discard and "just" need to turn this on by default for server libs? |
ohhh daaamn, okay nice, |
this is super helpful to know @pauldambra! |
cc: @liyiy |
This is now fixed :) |
Python and node only, but go, php still missing it: #18005 |
Is your feature request related to a problem?
Please describe.
I have a user in France, but when I send a backend event, I end up updating their country to USA, where my servers are. Big sad :/
Describe the solution you'd like
Have a special property on events, which if present, means no geoIP information is added, which is set on by default for all server libs. Update the geoIP plugin to respect this property.
Giving this control to users via the events they send is a lot more flexible than doing this on a plugin, which has complicated restrictions to get the same thing and not as flexible.
Describe alternatives you've considered
Right now, people have to go through multiple hoops, like adding the Advanced GeoIP plugin to discard geoIP information based on the library it is coming from.
Additional context
Thank you for your feature request – we love each and every one!
The text was updated successfully, but these errors were encountered: