Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GeoIP handling for server side & client side events more seamless #14351

Closed
neilkakkar opened this issue Feb 21, 2023 · 6 comments
Closed
Labels
enhancement New feature or request feature/feature-flags Feature Tag: Feature flags libraries Related to client libraries (except posthog-js)

Comments

@neilkakkar
Copy link
Collaborator

neilkakkar commented Feb 21, 2023

Is your feature request related to a problem?

Please describe.
I have a user in France, but when I send a backend event, I end up updating their country to USA, where my servers are. Big sad :/

Describe the solution you'd like

Have a special property on events, which if present, means no geoIP information is added, which is set on by default for all server libs. Update the geoIP plugin to respect this property.

Giving this control to users via the events they send is a lot more flexible than doing this on a plugin, which has complicated restrictions to get the same thing and not as flexible.

Describe alternatives you've considered

Right now, people have to go through multiple hoops, like adding the Advanced GeoIP plugin to discard geoIP information based on the library it is coming from.

Additional context

Thank you for your feature request – we love each and every one!

@neilkakkar neilkakkar added enhancement New feature or request feature/feature-flags Feature Tag: Feature flags libraries Related to client libraries (except posthog-js) labels Feb 21, 2023
@pauldambra
Copy link
Member

pauldambra commented Feb 21, 2023

In case I'm not misunderstanding....

If you'd like this app to skip over an event and not add the above properties, set property $geoip_disable to true on that event.

from https://posthog.com/docs/apps/geoip-enrichment#:~:text=If%20you%27d%20like%20this%20app%20to%20skip%20over%20an%20event%20and%20not%20add%20the%20above%20properties%2C%20set%20property%20%24geoip_disable%20to%20true%20on%20that%20event.

So, we can already instruct to discard and "just" need to turn this on by default for server libs?

@neilkakkar
Copy link
Collaborator Author

neilkakkar commented Feb 21, 2023

ohhh daaamn, okay nice, half 10% the work is done 😂

@paolodamico
Copy link
Contributor

this is super helpful to know @pauldambra!

@neilkakkar
Copy link
Collaborator Author

cc: @liyiy

@neilkakkar
Copy link
Collaborator Author

This is now fixed :)

@neilkakkar
Copy link
Collaborator Author

Python and node only, but go, php still missing it: #18005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature/feature-flags Feature Tag: Feature flags libraries Related to client libraries (except posthog-js)
Projects
None yet
Development

No branches or pull requests

3 participants