Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar can't override control variant #15481

Closed
hansottowirtz opened this issue May 10, 2023 · 3 comments
Closed

Toolbar can't override control variant #15481

hansottowirtz opened this issue May 10, 2023 · 3 comments
Labels
bug Something isn't working right

Comments

@hansottowirtz
Copy link

hansottowirtz commented May 10, 2023

Bug description

When using the toolbar to select the "control" variant, it is not overridden but the actual flag is passed.

How to reproduce

  1. Create an experiment, make sure the user has a variant that's not "control"
  2. Use the toolbar to select "control"
  3. onFeatureFlags is called with the variant assigned to the user (not "control")

Environment

/

Additional context

The feature flags are bootstrapped on posthog.init, but I'm not sure if that is relevant.

@hansottowirtz hansottowirtz added the bug Something isn't working right label May 10, 2023
@oleast
Copy link

oleast commented Aug 18, 2023

We're having the same problem with events triggered from addFeatureFlagHandler. The variant will never be control even when flipping between a control and test variant.

We're trying to set up an override that works with locally computed feature flags on the back-end. The only missing piece is to get the correct flags from the toolbar.

@neilkakkar
Copy link
Collaborator

I'd recommend using variant overrides inside the UI itself - these are made on our backend, are a lot more stable, and work everywhere, irrespective of the toolbar.

@neilkakkar
Copy link
Collaborator

This should be fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right
Projects
None yet
Development

No branches or pull requests

3 participants