Experiments HogQL rewrite

[jurajmajerik]

Trends

• Set up a query runner
• Retrieve Experiment
• Prepare Trend query
  • Display type
  • Start/end dates
  • Flag breakdown
• Prepare exposure query
  • Events/actions
  • Start/end dates
  • Flag breakdown
  • Default feature flag exposure filter
• Handle math aggregation path
• Add statistical calculations
• Custom errors
• Filter out test accounts
• Copy over existing tests
• Port holdout groups

Funnels

• Set up a query runner
• Retrieve Experiment
• Prepare Funnel query
  • Display type
  • Start/end dates
  • Flag breakdown
  • Reset properties
• Add statistical calculations
• Custom errors
• Filter out test accounts
• Copy over existing tests
• Port holdout groups

Schema migration

• Add a metrics field
• Validate metrics field
• Migrate Experiment records

Frontend

• Call /query for primary metric
• Call /query for secondary metrics
• Set insight (Form)
• Set insight (MetricSelector)
• Set insight (ActionFilter)
• ^^Repeat for the Trends exposure query
• ^^Repeat for secondary metrics
• Set query received from the Insight to filters/metrics
• Ensure backwards compatibility (transform filters to query)
• Retrieve from cache vs. recalculate

[abigailbramble]

https://posthoghelp.zendesk.com/agent/tickets/19665 and https://posthoghelp.zendesk.com/agent/tickets/19431
both seeing experiment results affected by anonymous events.
It looks like experiments are unintentionally filtering out anonymous people: see this thread
This will be fixed by the above migration.

[darkopia]

+1 to this. https://posthoghelp.zendesk.com/agent/tickets/20108
In this instance, removing any person property filters lead to matching results.