Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle repeated event steps in funnel #4813

Closed
EDsCODE opened this issue Jun 21, 2021 · 2 comments
Closed

Handle repeated event steps in funnel #4813

EDsCODE opened this issue Jun 21, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request feature/funnels Feature Tag: Funnels

Comments

@EDsCODE
Copy link
Member

EDsCODE commented Jun 21, 2021

Is your feature request related to a problem?

Please describe.
Currently, if you create a funnel with the exact same events in multiple steps, the funnel returns trivial results. If step_2 is $pageview and step_3 is $pageview, it doesn't find a later pageview but just counts the same step_2 pageview as a step_3 pageview. This is solved with windowFunnel because they added a strictly_increasing parameter. However, it's on a later version of clickhouse and we're looking to use the new query anyway.

Describe the solution you'd like

The new step query should look for a later pageview. This will require some query wrangling

Thank you for your feature request – we love each and every one!

@EDsCODE EDsCODE added the enhancement New feature or request label Jun 21, 2021
@EDsCODE EDsCODE changed the title Handle repeated events Handle repeated event steps iin funnel Jun 21, 2021
@EDsCODE EDsCODE added the feature/funnels Feature Tag: Funnels label Jun 21, 2021
@EDsCODE EDsCODE changed the title Handle repeated event steps iin funnel Handle repeated event steps in funnel Jun 21, 2021
@neilkakkar
Copy link
Contributor

Doesn't this become a non-issue with #4812 ? Since that will ensure the new step time to always be greater than previous step time?

Or is the crux here that when dealing with different kind of events, they don't have to be strictly increasing?

I think we can reasonably relax that constraint, such that all events follow a strictly increasing order, instead of just an increasing order?

Am I missing something?

@neilkakkar neilkakkar self-assigned this Jun 22, 2021
@EDsCODE
Copy link
Member Author

EDsCODE commented Jun 22, 2021

Query here: https://metabase.posthog.net/question/85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature/funnels Feature Tag: Funnels
Projects
None yet
Development

No branches or pull requests

2 participants