Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

linkable images #86

Open
renzy opened this issue Apr 3, 2018 · 5 comments
Open

linkable images #86

renzy opened this issue Apr 3, 2018 · 5 comments
Labels

Comments

@renzy
Copy link

renzy commented Apr 3, 2018

more of a req, but would be nice for people who don't know how to code html to make an image linkable with the cms. ive been able to do the this fine with html code block insert but no luck with the image insert button an then trying to link it.

might tweak it out myself, if i come up with a clean solution i can share if ya want. not sure if there is an underlying reason this isn't there though

@claviska
Copy link
Member

claviska commented Apr 3, 2018

You're supposed to be able to do this by inserting an image, then linking to it using CMD+K or the Link button in the toolbar. I just checked, and it looks like that no longer works in Chrome. (It looks like the selection is getting removed at some point.)

The first thing I'd try is a TinyMCE update. That usually fixes common browser quirks as they pop up in new versions.

It probably couldn't hurt to add a link input to the image panel too. I left it out originally because it seemed redundant, but I think it could be executed cleanly.

@M8inC
Copy link
Contributor

M8inC commented Sep 13, 2018

...ive been able to do the this fine with html code block insert....

Thanks for pointing me to this solution! ;)

@kylechine
Copy link

You're supposed to be able to do this by inserting an image, then linking to it using CMD+K or the Link button in the toolbar. I just checked, and it looks like that no longer works in Chrome. (It looks like the selection is getting removed at some point.)

The first thing I'd try is a TinyMCE update. That usually fixes common browser quirks as they pop up in new versions.

It probably couldn't hurt to add a link input to the image panel too. I left it out originally because it seemed redundant, but I think it could be executed cleanly.

I tried to add a link to an image by Link button. But it does not work.

@claviska claviska added the Bug label Dec 19, 2018
@claviska
Copy link
Member

Odd, I just replicated this and it seems like this really isn't working. I wonder if a browser update broke something along the way.

A quick guess is that the TinyMCE bookmark is being lost when the link is inserted. Or it could be trying to wrap the link around the <figure> and then the anchor gets cleaned by TinyMCE (since block-level anchors aren't supported).

@kylechine
Copy link

kylechine commented Dec 20, 2018

Currently, I have work around this by using HTML box directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants