Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owin.Scim should not touch meta.Created and meta.LastUpdated #30

Open
chihoyeung opened this issue Jun 9, 2016 · 2 comments
Open

Owin.Scim should not touch meta.Created and meta.LastUpdated #30

chihoyeung opened this issue Jun 9, 2016 · 2 comments

Comments

@chihoyeung
Copy link

(disclaimer: I wrote the original code that populated those values in UserService)

I think we should remove any code from inside Owin.Scim that populates these two fields, they should be the responsibility of the application server. In my particular case, the application server does not even persist creation/modify date for users, thus I want to return null - I do not see anything in the spec saying they are required.

Just wanted to put it out there for discussion before I go remove that code.

@dgioulakis
Copy link
Contributor

I think most implementors would rather this metadata be filled via business logic. It's their choice whether to persist it. Since no part of Resource.Meta is used during calculation of resource versioning, I wouldn't consider this an issue or design flaw.

@chihoyeung
Copy link
Author

I see two things I need:

  1. We need to modify Meta.Created and Meta.LastModified to nullable DateTime.
  2. We need to modify UserService and GroupService (in Owin.Scim) to not automatically populate these properties (since I don't persist them in the application server, I don't want to give any impression they exist at all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants