-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNSDist 1.8 crashes on DoH Query #12975
Comments
Can you post your configuration and full startup log? |
Startup log:
|
Config:
|
this seems important :) |
We use nginx in the front of dnsdist, so this should be fine and worked with 1.7 :). |
Looks like we hit this: When I remove this |
That's a very good lead, thanks! This fix was merged before 1.8.0 so it's probably slightly different, thought. |
Just to be sure, it doesn't crash but are the queries actually allowed, or are they then dropped by the ACL? |
When I remove the |
Without
With
|
Further investigation shows, it even crashes if I set |
Completely unrelated to your issue, but |
I reproduced the issue and should have a fix shortly. |
I just pushed a proposed fix in #12976. It is against master so I'll also open a PR for the 1.8.x branch. Would you be able to test it? I can generate packages for Ubuntu Jammy if that helps :) |
If you could generate a package for Ubuntu Focal I can test it right away :). |
Will do! |
There you go: https://downloads.powerdns.com/tmp/8348fdd4-0fb5-4e12-a4dd-803114eeccd9/ |
Looking good!
tcpdump:
So this is fixed. Awesome thank you for such a fast fix @rgacogne ! 🥳 |
Thanks a lot for reporting this issue and testing the fix, much appreciated! |
Short description
As soon as a DoH query is received DNSdist crashes
Environment
Enabled features: cdb dns-over-tls(gnutls openssl) dns-over-https(DOH) dnscrypt ebpf fstrm ipcipher libeditr libsodium lmdb outgoing-dns-over-https(nghttp2) protobuf re2 recvmmsg/sendmmsg snmp systemd
Steps to reproduce
Expected behaviour
Don't crash
Actual behaviour
Crashes
Other information
The text was updated successfully, but these errors were encountered: