Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid SOA in 1 zone causes full failure in pdns #7493

Closed
gizahNL opened this issue Feb 18, 2019 · 0 comments · Fixed by #7496
Closed

Invalid SOA in 1 zone causes full failure in pdns #7493

gizahNL opened this issue Feb 18, 2019 · 0 comments · Fixed by #7496

Comments

@gizahNL
Copy link

gizahNL commented Feb 18, 2019

  • Program: Authoritative
  • Issue type: Bug report

both version 4.0 and latest 4.1 (from debian repo's)

Short description

Invalid data within the SOA record in MySQL DB causes the full pdns server to crash, and not come back up due to repeatedly failing to load the record/zone.
Syslog mentions the following:
Feb 15 15:22:23 services-03 pdns_server[6907]: Exiting because communicator thread died with STL error: stoul; (invalid argument during std::stoul); data was "ns1.redacted.nl."

Environment

  • Operating system: Debian 9.8
  • Software version: pdns-server 4.1.6-1pdns.stretch
  • Software source: Debian repo's

Steps to reproduce

Insert invalid data into the SOA field for an authoritave zone i.e. (the data that caused the issue in our case):
| 159811 | 7036 | bestaatniet.local | SOA | SOA - ns1.redacted.nl. hostmaster.redacted.nl. 2019021500 28800 7200 604800 3600 3600 | 3600 | 0 | 1550240479 | 0 | NULL | 1 |
(NOTE: the contents column contains 'SOA -', the result of an unlucky copy paste error)

Expected behaviour

While db-record validation is not the responsibility of pdns one would expect that invalid data does not crash and burn the entire server; ideally only the zone in question should be broken.

Actual behaviour

The entire pdns daemon crashes and fails to return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants