Implements AnimateEntityPacket #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joserobjr
requested changes
Jun 23, 2021
There was a problem hiding this comment.
Thank you for the PR!
Can you do a few adjustments before I merge?
- Encapsulate the fields to avoid compatibility when Cloudburst Nukkit decides to add this packet
- Add the annotations below to all public stuff (except method overrides):
@PowerNukkitOnly
@Since("FUTURE")
src/main/java/cn/nukkit/network/protocol/AnimateEntityPacket.java
Outdated
Show resolved
Hide resolved
joserobjr
added
Type: enhancement
|
done |
|
I think it's worth adding the playAnimate() method to Entity.java |
joserobjr
added
Resolution: resolved
joserobjr
added a commit
that referenced
this pull request
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.