Enable set and test for Import resources
#464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
added
Doc-Impact
Schema-Impact
SteveL-MSFT
force-pushed
the
include-set-test
branch
from
9867d86 to
a706d91
Compare
anmenaga
approved these changes
Jun 18, 2024
| - name: nested | ||
| type: Microsoft.DSC/Include | ||
| properties: | ||
| configurationFile: "[concat('$echoConfigPathParent', '$directorySeparator', '$echoConfigPathLeaf')]" |
There was a problem hiding this comment.
why using concat instead of using just full path, aka $echoConfigPath ?
There was a problem hiding this comment.
It was to test that expressions get resolved for Include
| @@ -183,4 +174,38 @@ resources: | |||
| $out.results[1].result[0].result[0].type | Should -Be 'Test/Echo' | |||
| $out.results[1].result[0].result[0].result[0].actualState.output | Should -Be 'one' | |||
| } | |||
|
|
|||
| It 'Set with include works' { | |||
There was a problem hiding this comment.
Is there a test for test operation?
There was a problem hiding this comment.
It'll be added once test is complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This follows the PR to support
Importkind resources by enablingsetandtest. As part of this change, the output for group resources should also address #266. Note thattestis not complete yet as the engine currently just uses the input config as the desired state, but even after initial resolving of the include, that config still needs to have expressions invoked and parameters resolved for a valid comparison. That work will be addressed later.As part of this change, the
setgroup result andtestgroup result now align withgetwhich changes the schema.A helper function was added for
testto recursively determine if in desired state by looking forinDesiredStateproperty and if any are false than not in desired state (I think this might address #284)PR Context
Fix #266