Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect if dsc.exe is started from MSStore or Explorer and show a message and wait for key press #481

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

SteveL-MSFT
Copy link
Member

PR Summary

As part of the certification process to publish to MSStore, the tester will install the app and click Open in the MSStore GUI and expect something to happen. Since this is a command-line tool, it would not get required parameters, show help, and exit which to the tester looks like a crash so this prevents it from being published to the store publicly.

The change is to detect if the parent process is sihost.exe (name of the MSStore host that spawns apps) or explorer.exe and show a message directing them to https://aka.ms/dscv3-docs and wait for a key press before exiting.

To be able to test this, I had to create a new private version of the app so had to update build.ps1 to build a private version of the msix.

Steve Lee (POWERSHELL HE/HIM) (from Dev Box) added 2 commits July 2, 2024 14:22
@anmenaga
Copy link
Collaborator

anmenaga commented Jul 3, 2024

Can you please explain more why new $packageType=msix-private was needed?

@SteveL-MSFT
Copy link
Member Author

Can you please explain more why new $packageType=msix-private was needed?

Everytime I need to publish a test build to the Store, I need to increment the version number (you can't replace a published package even if it's not public). So I needed a "private" product name in the Store to use for testing.

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Jul 8, 2024
Merged via the queue into PowerShell:main with commit 7c55fc7 Jul 8, 2024
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the store-check branch July 8, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants