Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PSAdapter to properly handle multiple modules with same name #489

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Update PSAdapter to properly handle multiple modules with same name #489

merged 4 commits into from
Jul 13, 2024

Conversation

anmenaga
Copy link
Collaborator

PR Summary

Fix #487

  1. There was a bug if a module with same name is present in several locations in PSModulePath.
    This PR changes PSAdapter to select the module with highest version number in such cases.
  2. Plumbed resource 'Version' field to show up in dsc list. Resource version is taken from corresponding module version.

@anmenaga anmenaga marked this pull request as draft July 12, 2024 17:55
@anmenaga anmenaga marked this pull request as ready for review July 12, 2024 22:21
@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Jul 13, 2024
Merged via the queue into PowerShell:main with commit 6483333 Jul 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@tgauth tgauth Awaiting requested review from tgauth

Assignees
No one assigned
Labels
Doc-Impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PSDSCAdapter cannot process argument transformation
2 participants
@anmenaga @SteveL-MSFT