Skip to content

Commented out text still uncommented #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PrzemyslawKlys opened this issue Sep 27, 2018 · 3 comments
Closed

Commented out text still uncommented #148

PrzemyslawKlys opened this issue Sep 27, 2018 · 3 comments

Comments

@PrzemyslawKlys
Copy link

PrzemyslawKlys commented Sep 27, 2018

Environment

  • Editor and Version (VS Code, Atom, Sublime): VSCode
  • Your primary theme: Monokai

Issue Description

Pasting code as below shows .Link as still active

image

#write-host $link.Text
#write-host $link.Link

Expected Behavior

Commented out - same color

@msftrncs
Copy link
Contributor

msftrncs commented Oct 1, 2018

This is related to #136, documentation keywords being detected where not eligible or not detected where they should be (though it focuses on the not being detected part).

# .link is a documentation keyword that allows HELP to present useful links to the user. Its only supposed to be eligible when used at the start of a single line comment that starts a line or at the start of any line in a multi line comment.

@omniomi
Copy link
Contributor

omniomi commented Oct 1, 2018

@PrzemyslawKlys, this was actually fixed in PR #135. It hasn't been merged into Microsoft/vscode yet but should be soon.

You can use the latest build artifact if you would like the fix now: https://ci.appveyor.com/project/powershell/editorsyntax/branch/master/artifacts

@omniomi omniomi closed this as completed Oct 1, 2018
@PrzemyslawKlys
Copy link
Author

Thanks. I'll wait for official release :-) Not really big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants