This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Fix CI Pipeline and Opt-in to Meta Tests #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #200 +/- ##
===================================
Coverage 82% 82%
===================================
Files 19 19
Lines 2760 2760
Branches 4 4
===================================
Hits 2270 2270
Misses 486 486
Partials 4 4 |
|
@PlagueHO I rather @mgreenegit look and review this PR. Btw. integration tests seems to fail. |
|
I think the integration tests are failing because of the AppVeyor agent version (using a really old one). They pass when I specify recent version of agent (VS2019). But I can't check because I don't have access to the PowerShell AppVeyor config. Could probably set the agent version in the AppVeyor CI config though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR fixes the CI Pipeline by pinning Pester to 4.10.1. It also corrects the URLs for the Dev build badge and opts in to the meta tests:
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
@johlju - would you mind reviewing for me when you get time? I'd like to at least have CI process working on this module. cc @mgreenegit