Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Complete not working in WindowsTerminal #1380

Closed
SonOfDiablo opened this issue Feb 29, 2020 · 4 comments
Closed

Menu Complete not working in WindowsTerminal #1380

SonOfDiablo opened this issue Feb 29, 2020 · 4 comments

Comments

@SonOfDiablo
Copy link

Environment

PS version: 6.2.4
PSReadline version: 2.0.0-beta3
os: 10.0.18362.1 (WinBuild.160101.0800)
PS file version: 6.2.4.0
HostName: ConsoleHost (Windows Terminal)
BufferWidth: 241
BufferHeight: 55

Exception report

Steps to reproduce

Write a part of any command (example: Get-) then hit Ctrl+Space

Expected behavior

Running pwsh.exe directly works:
image

Actual behavior

Running pwsh.exe through WindowsTerminal (Nothing happens):
image

@ghost ghost added the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Feb 29, 2020
@daxian-dbw
Copy link
Member

I cannot repro this with the latest PSReadLine (version 2.0.0). You can get the latest PSReadLine from PowerShell Gallery. The "upgrading" instruction in README.md will be helpful.

norepro

@ghost ghost removed the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Mar 2, 2020
@lzybkr
Copy link
Member

lzybkr commented Mar 2, 2020

@daxian-dbw - your screen capture does not show MenuComplete working.

Ctrl+Space not working in Windows terminal is reported here: microsoft/terminal#2865

@daxian-dbw
Copy link
Member

I thought the author meant something different, as the "Expected Behavior" and "Actual Behavior" sections in the PR description indicate what author wants is what the GIF showed.

The menu completion works in Windows Terminal (v0.9.433.0) too:
image

@SonOfDiablo
Copy link
Author

After updating PSReadLine the MenuComplete (Ctrl+Space) actually works.
The Expected and Actual behavior descriptions might be a bit off, that one is my bad.

However it was the Ctrl+Space behavior I was talking about, it didn't trigger at all before, which is what I tried to show with the screenshots, though I must admit that it isn't super clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants