Skip to content

Commit 6b182e3

Browse files
authored
Add not yet implemented warning to save-psresource -asNupkg (#1009)
1 parent 33b78da commit 6b182e3

File tree

1 file changed

+17
-52
lines changed

1 file changed

+17
-52
lines changed

src/code/InstallHelper.cs

Lines changed: 17 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1091,65 +1091,30 @@ private List<PSResourceInfo> InstallPackage(
10911091

10921092
// Create the package extraction context
10931093
PackageExtractionContext packageExtractionContext = new PackageExtractionContext(
1094-
packageSaveMode: PackageSaveMode.Nupkg,
1095-
xmlDocFileSaveMode: PackageExtractionBehavior.XmlDocFileSaveMode,
1096-
clientPolicyContext: null,
1097-
logger: NullLogger.Instance);
1098-
1099-
// Extracting from .nupkg and placing files into tempInstallPath
1100-
result.PackageReader.CopyFiles(
1101-
destination: tempInstallPath,
1102-
packageFiles: result.PackageReader.GetFiles(),
1103-
extractFile: new PackageFileExtractor(
1104-
result.PackageReader.GetFiles(),
1105-
packageExtractionContext.XmlDocFileSaveMode).ExtractPackageFile,
1106-
logger: NullLogger.Instance,
1107-
token: _cancellationToken);
1108-
result.Dispose();
1109-
}
1110-
else
1111-
{
1112-
/* Download from a non-local repository */
1113-
// Set up NuGet API resource for download
1114-
PackageSource source = new PackageSource(repoUri);
1094+
packageSaveMode: PackageSaveMode.Nupkg,
1095+
xmlDocFileSaveMode: PackageExtractionBehavior.XmlDocFileSaveMode,
1096+
clientPolicyContext: null,
1097+
logger: NullLogger.Instance);
11151098

1116-
// Explicitly passed in Credential takes precedence over repository CredentialInfo
1117-
if (repoCredentialInfo != null)
1099+
if (_asNupkg)
11181100
{
1119-
PSCredential repoCredential = Utils.GetRepositoryCredentialFromSecretManagement(
1120-
repoName,
1121-
repoCredentialInfo,
1122-
_cmdletPassedIn);
1123-
1124-
string password = new NetworkCredential(string.Empty, repoCredential.Password).Password;
1125-
source.Credentials = PackageSourceCredential.FromUserInput(repoUri, repoCredential.UserName, password, true, null);
1101+
_cmdletPassedIn.WriteWarning("This feature is not yet implemented.");
11261102
}
1127-
1128-
var provider = FactoryExtensionsV3.GetCoreV3(NuGet.Protocol.Core.Types.Repository.Provider);
1129-
SourceRepository repository = new SourceRepository(source, provider);
1130-
1131-
/* Download from a non-local repository -- ie server */
1132-
var downloadResource = repository.GetResourceAsync<DownloadResource>().GetAwaiter().GetResult();
1133-
DownloadResourceResult result = null;
1134-
try
1103+
else
11351104
{
1136-
result = downloadResource.GetDownloadResourceResultAsync(
1137-
identity: pkgIdentity,
1138-
downloadContext: new PackageDownloadContext(cacheContext),
1139-
globalPackagesFolder: tempInstallPath,
1105+
// Extracting from .nupkg and placing files into tempInstallPath
1106+
result.PackageReader.CopyFiles(
1107+
destination: tempInstallPath,
1108+
packageFiles: result.PackageReader.GetFiles(),
1109+
extractFile: new PackageFileExtractor(
1110+
result.PackageReader.GetFiles(),
1111+
packageExtractionContext.XmlDocFileSaveMode).ExtractPackageFile,
11401112
logger: NullLogger.Instance,
1141-
token: _cancellationToken).GetAwaiter().GetResult();
1142-
}
1143-
catch (Exception e)
1144-
{
1145-
_cmdletPassedIn.WriteVerbose(string.Format("Error attempting download: '{0}'", e.Message));
1146-
}
1147-
finally
1148-
{
1149-
// Need to close the .nupkg
1150-
if (result != null) result.Dispose();
1113+
token: _cancellationToken);
11511114
}
1115+
result.Dispose();
11521116
}
1117+
11531118

11541119
_cmdletPassedIn.WriteVerbose(string.Format("Successfully able to download package from source to: '{0}'", tempInstallPath));
11551120

0 commit comments

Comments
 (0)