Save-PSResource with -WhatIf gives unexpected terminating error

[Gijsreyn]

Prerequisites

• Write a descriptive title.
• Make sure you are able to repro it on the latest released version
• Search the existing issues.

Steps to reproduce

Whenever adding the -WhatIf switch when saving a PowerShell module, the module doesn't give the what if response correctly. Instead, it terminates.

Steps to reproduce:

Run: Save-PSResource -Name WSManDsc -Path C:\temp -WhatIf

Expected behavior

Provide details about what if

Actual behavior

Gives both what if results and terminates.

Error details

Save-PSResource: Package(s) 'WSManDsc' could not be installed from repository 'PSGallery'.

Environment data

ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Binary     1.1.0      preview2   Microsoft.PowerShell.PSResourceGet  {Compress-PSResource, Find-PSResource, Get-Instal…


Name                           Value
----                           -----
PSVersion                      7.5.0
PSEdition                      Core
GitCommitId                    7.5.0
OS                             Microsoft Windows 10.0.26100
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visuals

No response

[o-l-a-v]

Should it though? Also, I can't reproduce.

PS > Save-PSResource -Name 'WSManDsc' -Path ([System.Environment]::GetFolderPath('Desktop') + '\Tes') -Debug -Verbose -WhatIf

DEBUG: In SavePSResource::ProcessSaveHelper()
DEBUG: In InstallHelper::BeginInstallPackages()
DEBUG: Parameters passed in >>> Name: 'WSManDsc'; VersionRange: ''; NuGetVersion: ''; VersionType: 'NoVersion'; Version: ''; Prerelease: 'False'; Repository: ''; AcceptLicense: 'False'; Quiet: 'False'; Reinstall: 'True'; TrustRepository: 'False'; NoClobber: 'False'; AsNupkg: 'False'; IncludeXml 'False'; SavePackage 'True'; TemporaryPath ''; SkipDependencyCheck: 'False'; AuthenticodeCheck: 'False'; PathsToInstallPkg: 'C:\Users\olav.birkeland\Desktop\Tes'; Scope ''
DEBUG: In InstallHelper::ProcessRepositories()
VERBOSE: Attempting to search for packages in 'PSGallery'
DEBUG: In InstallHelper::InstallPackages()
DEBUG: In InstallHelper::InstallPackage()
DEBUG: In V2ServerAPICalls::FindName()
DEBUG: In V2ServerAPICalls::HttpRequestCall()
DEBUG: Request url is 'https://www.powershellgallery.com/api/v2/FindPackagesById()?%24filter=Id+eq+%27WSManDsc%27+and+IsLatestVersion+eq+true&%24inlinecount=allpages&id=%27WSManDsc%27'
What if: Performing the operation "Save-PSResource" on target "Package to save: 'WSManDsc', version: '3.2.0'".
VERBOSE: Attempting to delete 'C:\Users\olav.birkeland\AppData\Local\Temp\f1077e38-c7f5-4b28-b0b7-d464dc4ca3ff'
VERBOSE: Successfully deleted 'C:\Users\olav.birkeland\AppData\Local\Temp\f1077e38-c7f5-4b28-b0b7-d464dc4ca3ff'

PS >

[Gijsreyn]

@o-l-a-v You're right, I should have payed more attention while writing. I've changed the title and description.

[o-l-a-v]

Whats the output with -Debug?

[Gijsreyn]

DEBUG: In SavePSResource::ProcessSaveHelper()
DEBUG: In InstallHelper::BeginInstallPackages()
DEBUG: Parameters passed in >>> Name: 'wsmandsc'; VersionRange: ''; NuGetVersion: ''; VersionType: 'NoVersion'; Version: ''; Prerelease: 'False'; Repository: 'PSGallery'; AcceptLicense: 'True'; Quiet: 'False'; Reinstall: 'True'; TrustRepository: 'False'; NoClobber: 'False'; AsNupkg: 'False'; IncludeXml 'False'; SavePackage 'True'; TemporaryPath ''; SkipDependencyCheck: 'False'; AuthenticodeCheck: 'False'; PathsToInstallPkg: 'C:\temp'; Scope ''
DEBUG: In InstallHelper::ProcessRepositories()
VERBOSE: Attempting to search for packages in 'PSGallery'
VERBOSE: Checking if untrusted repository should be used

Untrusted repository
You are installing the modules from an untrusted repository. If you trust this repository, change its Trusted value by
running the Set-PSResourceRepository cmdlet. Are you sure you want to install the PSResource from 'PSGallery'?
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "N"): y
DEBUG: In InstallHelper::InstallPackages()
DEBUG: In InstallHelper::InstallPackage()
DEBUG: In V2ServerAPICalls::FindName()
DEBUG: In V2ServerAPICalls::HttpRequestCall()
DEBUG: Request url is 'https://www.powershellgallery.com/api/v2/FindPackagesById()?%24filter=Id+eq+%27wsmandsc%27+and+IsLatestVersion&%24inlinecount=allpages&id=%27wsmandsc%27'
What if: Performing the operation "Save-PSResource" on target "Package to save: 'WSManDsc', version: '3.2.0'".
What if: Performing the operation "Save-PSResource" on target "Exit ShouldProcess".
VERBOSE: Attempting to delete 'C:\Users\Gijs\AppData\Local\Temp\e49e4f5f-84ce-4171-8bb9-85452d88c426'
VERBOSE: Successfully deleted 'C:\Users\Gijs\AppData\Local\Temp\e49e4f5f-84ce-4171-8bb9-85452d88c426'
Save-PSResource: Package(s) 'wsmandsc' could not be installed from repository 'PSGallery'.

[o-l-a-v]

Ah. I think this is fixed in v1.1.0 stable, seems you are using v1.1.0-preview2?

• Original issue: -WhatIf results in extra, unwanted output and a spurious error #1541
• PR: Fix 1541 "-WhatIf results in extra, unwanted output and a spurious error" #1711

[Gijsreyn]

I thought v1.1.0 was shipped with v7.5.0? If I have both on there, shouldn't v1.1.0 be the one to overrule? My module loading knowledge is a bit rusty.

[o-l-a-v]

From the "Environment data" section of the original post it says v1.1.0-preview2.

I've noticed that module loading is a can of worms. PowerShell will search though paths by the order of $env:PSModulePath in process context, and even lazy load (i think it was called that) DLLs while it searches for them.

• 190228: Migrate away from MEF for loading DLLs in Windows PowerShell PSScriptAnalyzer#1154
• 240208: Can't import v1.0.2 to pwsh.exe v7.4.1 with error "Import-Module: Assembly with same name is already loaded" PowerShell#21201
• 240208: PowerShell included modules does not have a version directory like Windows PowerShell had PowerShell#21199

So in some of my scripts I've implemented a workaround. Something like this:

$PsrgConflictingAssembly = [object](
    [Threading.Thread]::GetDomain().GetAssemblies().Where{
        -not [string]::IsNullOrEmpty($_.'Location') -and
        $_.'Location'.Contains('PSResourceGet') -and
        $_.'ManifestModule'.'Name' -eq 'Microsoft.PowerShell.PSResourceGet.dll'
    }[0]
)
if ([string]::IsNullOrEmpty($PsrgConflictingAssembly.'ManifestModule'.'Name')) {
    [System.Environment]::SetEnvironmentVariable(
        'PSModulePath',
        [System.Environment]::ExpandEnvironmentVariables(
            [System.Environment]::GetEnvironmentVariable('PSModulePath','User')
        ),
        'Process'
    )
    $null = Import-Module -Name 'Microsoft.PowerShell.PSResourceGet'
}
else {
    Import-Module -Name $PsrgConflictingAssembly.'ManifestModule'.'FullyQualifiedName'
}

[Gijsreyn]

That's pretty slick @o-l-a-v. Thanks for the response. I'll close this one. Sorry for the duplicate.

[o-l-a-v]

No problem. :) One can also load module by full path. Or remove paths from $env:PSModulePath in process context you don't want PowerShell to search through. More learnings in my issue here:

• Can't import v1.0.2 to pwsh.exe v7.4.1 with error "Import-Module: Assembly with same name is already loaded" PowerShell#21201

[o-l-a-v]

@Gijsreyn: Now I finally remember why this happens. I made a easy repro here:

PowerShell/PowerShell#21201 (comment)

It's very annoying indeed. 😑

[Gijsreyn]

@Gijsreyn: Now I finally remember why this happens. I made a easy repro here:

PowerShell/PowerShell#21201 (comment)

It's very annoying indeed. 😑

Thanks for the share and providing such detail.