Compatibility tests: Use correct genericVerCases test case and remove invalid test case (#1440)

bergmeister · web-flow · commit 03aa0853fd04 · 2020-04-16T21:55:24.000+01:00
diff --git a/PSCompatibilityCollector/Tests/UtilityApi.Tests.ps1 b/PSCompatibilityCollector/Tests/UtilityApi.Tests.ps1
@@ -101,7 +101,6 @@ Describe "PowerShell version object" {
     Context "Version parsing" {
         BeforeAll {
             $genericVerCases = @(
-                @{ VerStr = '6'; Major = 6; Minor = -1; Patch = -1 }
                 @{ VerStr = '6.1'; Major = 6; Minor = 1; Patch = -1 }
                 @{ VerStr = '5.2.7'; Major = 5; Minor = 2; Patch = 7 }
                 @{ VerStr = '512.2124.71'; Major = 512; Minor = 2124; Patch = 71 }
@@ -134,7 +133,7 @@ Describe "PowerShell version object" {
             )
         }
 
-        It "Parses version string '<VerStr>' as <Major>.<Minor>.<Patch>" -TestCases $semVerCases {
+        It "Parses version string '<VerStr>' as <Major>.<Minor>.<Patch>" -TestCases $genericVerCases {
             param([string]$VerStr, [int]$Major, [int]$Minor, [int]$Patch)
 
             $v = [Microsoft.PowerShell.CrossCompatibility.PowerShellVersion]$VerStr

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,6 @@ Describe "PowerShell version object" {`
`101`	`101`	`Context "Version parsing" {`
`102`	`102`	`BeforeAll {`
`103`	`103`	`$genericVerCases = @(`
`104`		`- @{ VerStr = '6'; Major = 6; Minor = -1; Patch = -1 }`
`105`	`104`	`@{ VerStr = '6.1'; Major = 6; Minor = 1; Patch = -1 }`
`106`	`105`	`@{ VerStr = '5.2.7'; Major = 5; Minor = 2; Patch = 7 }`
`107`	`106`	`@{ VerStr = '512.2124.71'; Major = 512; Minor = 2124; Patch = 71 }`
`@@ -134,7 +133,7 @@ Describe "PowerShell version object" {`
`134`	`133`	`)`
`135`	`134`	`}`
`136`	`135`
`137`		`- It "Parses version string '<VerStr>' as <Major>.<Minor>.<Patch>" -TestCases $semVerCases {`
	`136`	`+ It "Parses version string '<VerStr>' as <Major>.<Minor>.<Patch>" -TestCases $genericVerCases {`
`138`	`137`	`param([string]$VerStr, [int]$Major, [int]$Minor, [int]$Patch)`
`139`	`138`
`140`	`139`	`$v = [Microsoft.PowerShell.CrossCompatibility.PowerShellVersion]$VerStr`