Update Newtonsoft json to 12.0.1 due to PowerShell 6.1 going out of support (#1336)

* Upgrade NewtonSoft.Json to the version that PS 6.2.1 ships with as PS 6.1 is going out of support now

* Upgrade AppVeyor image to use PS 6.2

* Downgrade to PS 6.2.0 as a minimum PS version due to AppVeyor

Author: bergmeister

Engine/PSScriptAnalyzer.psm1

@@ -13,8 +13,12 @@ $binaryModuleRoot = $PSModuleRoot
 
 if (($PSVersionTable.Keys -contains "PSEdition") -and ($PSVersionTable.PSEdition -ne 'Desktop')) {
     $binaryModuleRoot = Join-Path -Path $PSModuleRoot -ChildPath 'coreclr'
-    if ($PSVersionTable.PSVersion -lt [Version]'6.1.0') {
-        throw "Minimum supported version of PSScriptAnalyzer for PowerShell Core is 6.1.0 but current version is '$($PSVersionTable.PSVersion)'. Please update PowerShell Core."
+    # Minimum PowerShell Core version given by PowerShell Core support itself and
+    # also the version of NewtonSoft.Json implicitly that PSSA ships with,
+    # which cannot be higher than the one that PowerShell ships with.
+    [Version] $minimumPowerShellCoreVersion = '6.2.0'
+    if ($PSVersionTable.PSVersion -lt $minimumPowerShellCoreVersion) {
+        throw "Minimum supported version of PSScriptAnalyzer for PowerShell Core is $minimumPowerShellCoreVersion but current version is '$($PSVersionTable.PSVersion)'. Please update PowerShell Core."
     }
 }
 elseif ($PSVersionTable.PSVersion.Major -eq 5) {

PSCompatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Microsoft.PowerShell.CrossCompatibility.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;net452</TargetFrameworks>
@@ -20,7 +20,7 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
     <PackageReference Include="Microsoft.Management.Infrastructure" Version="1.0.0" />
-    <PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
+    <PackageReference Include="Newtonsoft.Json" Version="12.0.1" />
   </ItemGroup>
 
 </Project>

Rules/Rules.csproj

@@ -10,7 +10,7 @@
 
   <ItemGroup>
     <ProjectReference Include="..\Engine\Engine.csproj" />
-    <PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
+    <PackageReference Include="Newtonsoft.Json" Version="12.0.1" />
     <PackageReference Include="Microsoft.Management.Infrastructure" Version="1.0.0" />
   </ItemGroup>
 

appveyor.yml

@@ -3,7 +3,7 @@ environment:
   BuildConfiguration: Release
   DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true # For faster CI builds
   matrix:
-  - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
+  - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
     PowerShellEdition: PowerShellCore
   - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
     PowerShellEdition: WindowsPowerShell