Skip to content

Improve configuration #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rjmholt opened this issue May 6, 2020 · 1 comment
Open

Improve configuration #1479

rjmholt opened this issue May 6, 2020 · 1 comment
Milestone

Comments

@rjmholt
Copy link
Contributor

rjmholt commented May 6, 2020

Configuration of PSSA2 should be easier.

In particular:

  • Misconfigurations should present a useful error to users about expectation vs what was given
  • Configuration should take a list of rule configurations and implicitly turn them into a dictionary, rather than require null dictionary entries
  • Perhaps add more here
@rjmholt rjmholt added this to the 2.0 milestone May 6, 2020
@ghost ghost added the Needs: Triage 🔍 label May 6, 2020
@bergmeister
Copy link
Collaborator

Have a think about how config should work from the editors POV as well. At the moment all individual configuration are exposed as individual settings to individually override the default settings. If we simplified it to a few JSON objects, we need to make sure that this is not the actual configuration but only the configuration overrides. This way the concept of the PSSA settings file would only be useful when using the cmdlets directly but editor users would only configure vs code settings.
How would user and workspace settings combine if it was a big object instead of just 1 value? VS-Code has the concept that workspace settings override user settings but in this case we don't want that on the whole object but only the individual properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants