Skip to content

Commit 76a5791

Browse files
committedDec 28, 2021
Simplify application of Trait in DebugServiceTests
1 parent 44a179c commit 76a5791

File tree

1 file changed

+1
-23
lines changed

1 file changed

+1
-23
lines changed
 

Diff for: ‎test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs

+1-23
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
using Xunit;
2020
namespace Microsoft.PowerShell.EditorServices.Test.Debugging
2121
{
22+
[Trait("Category", "DebugService")]
2223
public class DebugServiceTests : IDisposable
2324
{
2425
private readonly PsesInternalHost psesHost;
@@ -133,7 +134,6 @@ private Task<IReadOnlyList<LineBreakpoint>> GetConfirmedBreakpoints(ScriptFile s
133134
CancellationToken.None);
134135
}
135136

136-
[Trait("Category", "DebugService")]
137137
[Fact]
138138
// This regression test asserts that `ExecuteScriptWithArgsAsync` works for both script
139139
// files and, in this case, in-line scripts (commands). The bug was that the cwd was
@@ -162,7 +162,6 @@ await debugService.SetCommandBreakpointsAsync(
162162
Assert.Equal("[ArrayList: 0]", var.ValueString);
163163
}
164164

165-
[Trait("Category", "DebugService")]
166165
[Fact]
167166
public async Task DebuggerAcceptsScriptArgs()
168167
{
@@ -224,7 +223,6 @@ public async Task DebuggerAcceptsScriptArgs()
224223
Assert.Equal("\"Extra1\"", childVars[0].ValueString);
225224
}
226225

227-
[Trait("Category", "DebugService")]
228226
[Fact]
229227
public async Task DebuggerSetsAndClearsFunctionBreakpoints()
230228
{
@@ -250,7 +248,6 @@ public async Task DebuggerSetsAndClearsFunctionBreakpoints()
250248
Assert.Empty(breakpoints);
251249
}
252250

253-
[Trait("Category", "DebugService")]
254251
[Fact]
255252
public async Task DebuggerStopsOnFunctionBreakpoints()
256253
{
@@ -283,7 +280,6 @@ public async Task DebuggerStopsOnFunctionBreakpoints()
283280
Assert.Equal("2", i.ValueString);
284281
}
285282

286-
[Trait("Category", "DebugService")]
287283
[Fact]
288284
public async Task DebuggerSetsAndClearsLineBreakpoints()
289285
{
@@ -317,7 +313,6 @@ await debugService.SetLineBreakpointsAsync(
317313
Assert.Empty(remainingBreakpoints);
318314
}
319315

320-
[Trait("Category", "DebugService")]
321316
[Fact]
322317
public async Task DebuggerStopsOnLineBreakpoints()
323318
{
@@ -334,7 +329,6 @@ await debugService.SetLineBreakpointsAsync(
334329
AssertDebuggerStopped(debugScriptFile.FilePath, 7);
335330
}
336331

337-
[Trait("Category", "DebugService")]
338332
[Fact]
339333
public async Task DebuggerStopsOnConditionalBreakpoints()
340334
{
@@ -374,7 +368,6 @@ await debugService.SetLineBreakpointsAsync(
374368
Assert.Equal($"{breakpointValue2}", i.ValueString);
375369
}
376370

377-
[Trait("Category", "DebugService")]
378371
[Fact]
379372
public async Task DebuggerStopsOnHitConditionBreakpoint()
380373
{
@@ -399,7 +392,6 @@ await debugService.SetLineBreakpointsAsync(
399392
Assert.Equal($"{hitCount}", i.ValueString);
400393
}
401394

402-
[Trait("Category", "DebugService")]
403395
[Fact]
404396
public async Task DebuggerStopsOnConditionalAndHitConditionBreakpoint()
405397
{
@@ -423,7 +415,6 @@ await debugService.SetLineBreakpointsAsync(
423415
Assert.Equal("10", i.ValueString);
424416
}
425417

426-
[Trait("Category", "DebugService")]
427418
[Fact]
428419
public async Task DebuggerProvidesMessageForInvalidConditionalBreakpoint()
429420
{
@@ -452,7 +443,6 @@ await debugService.SetLineBreakpointsAsync(
452443
Assert.Contains("Unexpected token '-ez'", breakpoints[0].Message);
453444
}
454445

455-
[Trait("Category", "DebugService")]
456446
[Fact]
457447
public async Task DebuggerFindsParseableButInvalidSimpleBreakpointConditions()
458448
{
@@ -475,7 +465,6 @@ await debugService.SetLineBreakpointsAsync(
475465
Assert.Contains("Use '-gt' instead of '>'", breakpoints[1].Message);
476466
}
477467

478-
[Trait("Category", "DebugService")]
479468
[Fact]
480469
public async Task DebuggerBreaksWhenRequested()
481470
{
@@ -487,7 +476,6 @@ public async Task DebuggerBreaksWhenRequested()
487476
AssertDebuggerPaused();
488477
}
489478

490-
[Trait("Category", "DebugService")]
491479
[Fact]
492480
public async Task DebuggerRunsCommandsWhileStopped()
493481
{
@@ -502,7 +490,6 @@ public async Task DebuggerRunsCommandsWhileStopped()
502490
Assert.Equal(17, (await executeTask.ConfigureAwait(true))[0]);
503491
}
504492

505-
[Trait("Category", "DebugService")]
506493
[Fact]
507494
public async Task DebuggerVariableStringDisplaysCorrectly()
508495
{
@@ -522,7 +509,6 @@ await debugService.SetLineBreakpointsAsync(
522509
Assert.False(var.IsExpandable);
523510
}
524511

525-
[Trait("Category", "DebugService")]
526512
[Fact]
527513
public async Task DebuggerGetsVariables()
528514
{
@@ -573,7 +559,6 @@ await debugService.SetLineBreakpointsAsync(
573559
Assert.Equal("$false", falseVar.ValueString);
574560
}
575561

576-
[Trait("Category", "DebugService")]
577562
[Fact(Skip = "Variable setting is broken")]
578563
public async Task DebuggerSetsVariablesNoConversion()
579564
{
@@ -634,7 +619,6 @@ await debugService.SetLineBreakpointsAsync(
634619
Assert.Equal(newGlobalIntValue, intGlobalVar.ValueString);
635620
}
636621

637-
[Trait("Category", "DebugService")]
638622
[Fact(Skip = "Variable setting is broken")]
639623
public async Task DebuggerSetsVariablesWithConversion()
640624
{
@@ -698,7 +682,6 @@ await debugService.SetLineBreakpointsAsync(
698682
Assert.Equal(newGlobalValue, globalVar.ValueString);
699683
}
700684

701-
[Trait("Category", "DebugService")]
702685
[Fact]
703686
public async Task DebuggerVariableEnumDisplaysCorrectly()
704687
{
@@ -719,7 +702,6 @@ await debugService.SetLineBreakpointsAsync(
719702
Assert.False(var.IsExpandable);
720703
}
721704

722-
[Trait("Category", "DebugService")]
723705
[Fact]
724706
public async Task DebuggerVariableHashtableDisplaysCorrectly()
725707
{
@@ -756,7 +738,6 @@ await debugService.SetLineBreakpointsAsync(
756738
}
757739
}
758740

759-
[Trait("Category", "DebugService")]
760741
[Fact]
761742
public async Task DebuggerVariableNullStringDisplaysCorrectly()
762743
{
@@ -777,7 +758,6 @@ await debugService.SetLineBreakpointsAsync(
777758
Assert.True(nullStringVar.IsExpandable);
778759
}
779760

780-
[Trait("Category", "DebugService")]
781761
[Fact]
782762
public async Task DebuggerVariablePSObjectDisplaysCorrectly()
783763
{
@@ -805,7 +785,6 @@ await debugService.SetLineBreakpointsAsync(
805785
Assert.Equal("\"John\"", childVars["Name"]);
806786
}
807787

808-
[Trait("Category", "DebugService")]
809788
[Fact]
810789
public async Task DebuggerVariablePSCustomObjectDisplaysCorrectly()
811790
{
@@ -835,7 +814,6 @@ await debugService.SetLineBreakpointsAsync(
835814

836815
// Verifies fix for issue #86, $proc = Get-Process foo displays just the ETS property set
837816
// and not all process properties.
838-
[Trait("Category", "DebugService")]
839817
[Fact(Skip = "Length of child vars is wrong now")]
840818
public async Task DebuggerVariableProcessObjDisplaysCorrectly()
841819
{

0 commit comments

Comments
 (0)