Remove BinClean dependency from build task (#1589)

JustinGrote · web-flow · commit ccf1a8dda9eb · 2021-10-18T09:49:00.000-07:00
MSBuild does incremental builds by nature, it is not necessary to do a clean and slows down subsequent builds. "Clean" task should be called if a clean is in fact required.
diff --git a/PowerShellEditorServices.build.ps1 b/PowerShellEditorServices.build.ps1
@@ -210,7 +210,7 @@ task SetupHelpForTests {
     }
 }
 
-task Build BinClean,{
+Task Build {
     exec { & $script:dotnetExe publish -c $Configuration .\src\PowerShellEditorServices\PowerShellEditorServices.csproj -f $script:NetRuntime.Standard }
     exec { & $script:dotnetExe publish -c $Configuration .\src\PowerShellEditorServices.Hosting\PowerShellEditorServices.Hosting.csproj -f $script:NetRuntime.PS7 }
     if (-not $script:IsNix)

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ task SetupHelpForTests {`
`210`	`210`	`}`
`211`	`211`	`}`
`212`	`212`
`213`		`-task Build BinClean,{`
	`213`	`+Task Build {`
`214`	`214`	`exec { & $script:dotnetExe publish -c $Configuration .\src\PowerShellEditorServices\PowerShellEditorServices.csproj -f $script:NetRuntime.Standard }`
`215`	`215`	`exec { & $script:dotnetExe publish -c $Configuration .\src\PowerShellEditorServices.Hosting\PowerShellEditorServices.Hosting.csproj -f $script:NetRuntime.PS7 }`
`216`	`216`	`if (-not $script:IsNix)`