Skip to content

Adding -Force switch to ConfirmImpact=High functions #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

giuseppecampanelli
Copy link
Contributor

@giuseppecampanelli giuseppecampanelli commented Jun 7, 2020

Description

Adding -Force switch to ConfirmImpact=High functions and tests

Issues Fixed

Fixes #218

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

@giuseppecampanelli
Copy link
Contributor Author

@X-Guardian I've applied your changes 👍

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this!

Minor formatting change request that differs from the source article, and then this should be ready for CI verification and then merging.

@HowardWolosky
Copy link
Member

Thanks @X-Guardian for giving this an early review!

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks so much for doing this. This is definitely going to make the Remove-* methods easier (and more natural) to use.

Will kick off a CI for this once the current one ends and merge it pending success.

Thanks again for your contribution! Looking forward to see what you pick up next!

#230 would be an easy one to knock off if you're interested in picking up another bug.

@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky HowardWolosky merged commit 3c642d2 into microsoft:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add -Force parameter on any ConfirmImpact="High" cmdlets
3 participants