Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlAlias: Need to remove ShouldProcess from code #242

Closed
johlju opened this issue Dec 12, 2016 · 0 comments · Fixed by #1348
Closed

SqlAlias: Need to remove ShouldProcess from code #242

johlju opened this issue Dec 12, 2016 · 0 comments · Fixed by #1348
Assignees
@johlju
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Dec 12, 2016

Details of the scenario you try and problem that is occurring:
This resource is using non supported functions. Best practices are to not use ShouldProcess in DSC resources.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added easy fix enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Dec 12, 2016
@johlju johlju added the good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub label Oct 12, 2017
@johlju johlju changed the title xSQLServerAlias: Need to remove ShouldProcess from code SqlAlias: Need to remove ShouldProcess from code Dec 23, 2017
@johlju johlju removed the easy fix label Apr 29, 2018
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Apr 28, 2019
johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 28, 2019
@johlju
Changes to SqlAlias
12af394 
- Added en-US localization (issue dsccommunity#602).
- Removed ShouldProcess for the code, since it has no purpose in a DSC
  resource (issue dsccommunity#242).
@johlju johlju mentioned this issue Apr 28, 2019
Merged
9 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 30, 2019
@johlju
Changes to SqlAlias
4a42fbc 
- Added en-US localization (issue dsccommunity#602).
- Removed ShouldProcess for the code, since it has no purpose in a DSC
  resource (issue dsccommunity#242).
johlju added a commit that referenced this issue Apr 30, 2019
@johlju
SqlAlias: Added localization (#1348)
ef60c85 
- Changes to SqlAlias
  - Added en-US localization (issue #602).
  - Removed ShouldProcess for the code, since it has no purpose in a DSC
    resource (issue #242).
@kwirkykat kwirkykat removed the in progress The issue is being actively worked on by someone. label Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlAlias: Added localization johlju/SqlServerDsc
2 participants
@kwirkykat @johlju