Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlSetup: Localization messages could be improved for Robocopy #694

Closed
johlju opened this issue Jul 17, 2017 · 0 comments · Fixed by #1323
Closed

SqlSetup: Localization messages could be improved for Robocopy #694

johlju opened this issue Jul 17, 2017 · 0 comments · Fixed by #1323
Assignees
@johlju
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jul 17, 2017

Details of the scenario you tried and the problem that is occurring:
Instead of having a separate localization message for the key RobocopySuccessfulAndRemovedExtraFilesAtDestination it could be put together using the keys RobocopySuccessful and RobocopyRemovedExtraFilesAtDestination .

    RobocopySuccessful = Robocopy copied files successfully
    RobocopyRemovedExtraFilesAtDestination = Robocopy found files at the destination path that is not present at the source path, these extra files was remove at the destination path.
    RobocopySuccessfulAndRemovedExtraFilesAtDestination = Robocopy copied files to destination successfully. Robocopy also found files at the destination path that is not present at the source path, these extra files was remove at the destination path.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. easy fix labels Jul 17, 2017
@johlju johlju added the good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub label Oct 12, 2017
@johlju johlju changed the title xSQLServerSetup: Localization messages could be improved for Robocopy SqlSetup: Localization messages could be improved for Robocopy Dec 22, 2017
@johlju johlju removed the easy fix label Apr 29, 2018
johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 17, 2019
@johlju
Changes to SqlSetup
a1d0269 
- Concatenated Robocopy localization strings (issue dsccommunity#694).
@johlju johlju mentioned this issue Apr 17, 2019
Merged
9 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Apr 17, 2019
johlju added a commit that referenced this issue Apr 22, 2019
@johlju
SqlSetup: Concatenated Robocopy localization strings (#1323)
7a05776 
- Changes to SqlSetup
  - Concatenated Robocopy localization strings (issue #694).
@kwirkykat kwirkykat removed the in progress The issue is being actively worked on by someone. label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlSetup: Concatenated Robocopy localization strings johlju/SqlServerDsc
2 participants
@kwirkykat @johlju