Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: SqlServerDsc: The resource module has been renamed #916

Closed
johlju opened this issue Nov 28, 2017 · 1 comment · Fixed by #919
Closed

BREAKING CHANGE: SqlServerDsc: The resource module has been renamed #916

johlju opened this issue Nov 28, 2017 · 1 comment · Fixed by #919
Assignees
@johlju
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Nov 28, 2017 •
edited
Loading

Details of the scenario you tried and the problem that is occurring:
The resource module has been renamed to SqlServerDsc. We should reflect that in the CHANGELOG.md

It was rename as part of issue #851. When that major breaking change was done we took the opportunity to rename the resource module as well.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Nov 28, 2017
@johlju johlju changed the title SqlServerDsc: The resource module has been renamed BREAKING CHANGE: SqlServerDsc: The resource module has been renamed Nov 28, 2017
@johlju
Copy link
Member Author

johlju commented Nov 28, 2017

Maybe not a breaking change depending how you look at it, but I will label it so anyway. :)

@johlju johlju mentioned this issue Nov 28, 2017
Merged
5 tasks
johlju added a commit that referenced this issue Nov 29, 2017
@johlju
SqlServerDsc: Fix CHANGELOG.md after resource module rename (#919)
99ad8a2 
- BREAKING CHANGE: Resource module has been renamed to SqlServerDsc (issue #916).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Fix CHANGELOG.md after resource module rename johlju/SqlServerDsc
1 participant
@johlju