Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServiceAccount: Integration test is missing for this resource #980

Closed
johlju opened this issue Dec 30, 2017 · 0 comments · Fixed by #987
Closed

SqlServiceAccount: Integration test is missing for this resource #980

johlju opened this issue Dec 30, 2017 · 0 comments · Fixed by #987
Assignees
@johlju
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Dec 30, 2017

Details of the scenario you tried and the problem that is occurring:
We should add an integration test for this resource.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Dec 30, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Dec 30, 2017
@johlju
Changes to SqlServiceAccount
077be85 
- Added integration tests (issue dsccommunity#980).
@johlju johlju mentioned this issue Dec 30, 2017
Merged
5 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 1, 2018
@johlju
Changes to SqlServiceAccount
45f8dbc 
- Added integration tests (issue dsccommunity#980).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 1, 2018
@johlju
Changes to SqlServiceAccount
934a53c 
- Added integration tests (issue dsccommunity#980).
johlju added a commit that referenced this issue Jan 4, 2018
@johlju
SqlServiceAccount: Added integration tests (plus other changes) (#987)
2631d70 
- Changes to SqlServerDsc
  - Added a README.md under Tests\Integration to help contributors to write
   integration tests.
  - Added 'Integration tests' section in the CONTRIBUTING.md.
- Changes to SqlServiceAccount
  - Added a read-only parameter ServiceAccountName so that the service account
    name is correctly returned as a string (issue #982).
  - Added integration tests (issue #980).
- Changes to SqlSetup
  - Cleaned up integration tests.
  - Added integration tests for installing a default instance of Database Engine.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServiceAccount: Added integration tests (plus other changes) johlju/SqlServerDsc
1 participant
@johlju