Skip to content

Commit 80f7940

Browse files
Update recommended PowerShell LTS (#5186)
1 parent f172092 commit 80f7940

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

docs/troubleshooting.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ active editor's language mode is PowerShell.
1515

1616
### Using Windows PowerShell 5.1
1717

18-
While we _highly encourage_ the use of [PowerShell Core 7.2][], if you must use Windows
18+
While we _highly encourage_ the use of [PowerShell 7.4 LTS][], if you must use Windows
1919
PowerShell 5.1 we attempt to support it on a best-effort basis. Unfortunately, being two
2020
major versions behind and in maintenance mode, Windows PowerShell is missing many of the
2121
bug fixes and APIs we use to make the extension experience great. So please, if you can,
@@ -410,7 +410,7 @@ WSManStackVersion 3.0
410410
[more information]: #providing-information-about-your-environment
411411
[open a new issue]: https://github.com/PowerShell/vscode-powershell/issues/new/choose
412412
[open an issue there]: https://github.com/PowerShell/PSScriptAnalyzer/issues/new/choose
413-
[PowerShell Core 7.2]: https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-on-windows?view=powershell-7.2
413+
[PowerShell 7.4 LTS]: https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-on-windows?view=powershell-7.4
414414
[semantic highlighting]: https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide
415415
[tackling an issue]: ./development.md
416416
[v2021.2.2]: https://github.com/PowerShell/vscode-powershell/releases/tag/v2021.2.2

test/features/UpdatePowerShell.test.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,9 @@ describe("UpdatePowerShell feature", function () {
128128
// @ts-expect-error method is private.
129129
const tag: string | undefined = await updater.maybeGetNewRelease();
130130
// NOTE: This will need to be updated each new major stable.
131-
assert(tag?.startsWith("v7.5"));
131+
// TODO: Upstream bug causes LTS releases to update the stable info.
132+
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
133+
assert(tag?.startsWith("v7.5") || tag?.startsWith("v7.4"));
132134
});
133135
});
134136
});

0 commit comments

Comments
 (0)