actually hide terminal until debug session (#2437)

Author: TylerLeonhardt

package-lock.json

@@ -6,7 +6,7 @@
   "publisher": "ms-vscode",
   "description": "(Preview) Develop PowerShell scripts in Visual Studio Code!",
   "engines": {
-    "vscode": "^1.34.0"
+    "vscode": "^1.40.0"
   },
   "license": "SEE LICENSE IN LICENSE.txt",
   "homepage": "https://github.com/PowerShell/vscode-powershell/blob/master/README.md",
@@ -57,7 +57,7 @@
     "@types/rewire": "~2.5.28",
     "@types/semver": "~6.2.0",
     "@types/sinon": "~7.5.1",
-    "@types/vscode": "1.34.0",
+    "@types/vscode": "1.40.0",
     "mocha": "~5.2.0",
     "mocha-junit-reporter": "~1.23.2",
     "mocha-multi-reporters": "~1.1.7",

package.json

@@ -108,12 +108,15 @@ export class PowerShellProcess {
 
                     // Launch PowerShell in the integrated terminal
                     this.consoleTerminal =
-                        vscode.window.createTerminal(
-                            this.title,
-                            this.exePath,
-                            powerShellArgs);
+                        vscode.window.createTerminal({
+                            name: this.title,
+                            shellPath: this.exePath,
+                            shellArgs: powerShellArgs,
+                            hideFromUser: !this.sessionSettings.integratedConsole.showOnStartup,
+                        });
 
                     if (this.sessionSettings.integratedConsole.showOnStartup) {
+                        // We still need to run this to set the active terminal to the Integrated Console.
                         this.consoleTerminal.show(true);
                     }