Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command flags not visible #2636

Closed
0x57e11a opened this issue Apr 15, 2020 · 4 comments
Closed

Command flags not visible #2636

0x57e11a opened this issue Apr 15, 2020 · 4 comments
Labels
Resolution-External Will close automatically.

Comments

@0x57e11a
Copy link

System Details

System Details Output

### VSCode version: 1.44.0 2aae1f26c72891c399f860409176fe435a154b13 x64

### VSCode extensions:
acidic9.glua@0.1.7
akamud.vscode-theme-onedark@2.2.1
alexcvzz.vscode-sqlite@0.8.1
dbaeumer.vscode-eslint@2.1.3
esbenp.prettier-vscode@4.4.0
gerane.Theme-Solarized-dark@0.0.5
ginfuru.ginfuru-better-solarized-dark-theme@0.9.4
glitch.glitch@0.1.6
icrawl.discord-vscode@3.13.0
KnisterPeter.vscode-github@0.30.3
ms-azuretools.vscode-docker@1.0.0
ms-vscode-remote.remote-wsl@0.44.2
stringham.move-ts@1.12.0
StroupBSlayen.vscord@0.5.2
tiibun.vscode-docker-ws@0.4.1


### PSES version:

### PowerShell version:

Name                           Value
----                           -----
PSVersion                      5.1.18362.628
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.18362.628
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

The color of command flags, they are invisible due to being the same color as the background, I use Solarized Dark, and command flags seem to use the same/a similar color, therefore they are invisible

Expected Behaviour

Command flags are invisible

Actual Behaviour

It should show command flags in a visible color

Am new to posting here, forgive me if I did something wrong

@ghost ghost added the Needs: Triage Maintainer attention needed! label Apr 15, 2020
@corbob
Copy link
Contributor

corbob commented Apr 16, 2020

I'm going to say that this is either an issue with PSReadLine, or with Solarized Dark itself. For instance when using Solarized Dark with Windows Terminal I get the same thing:
image (in fact, this is one of the reasons I stopped using Solarized because I couldn't be bothered to sort out the color issue)

Of course, I'm not actually able to reproduce this issue in vscode 1.45 🤔

@rjmholt
Copy link
Contributor

rjmholt commented Apr 16, 2020

I believe you can reconfigure the colours in your $profile; @TylerLeonhardt or @SteveL-MSFT may have some advice there

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Apr 16, 2020

Yep, I have this in my $PROFILE:

Set-PSReadLineOption -Colors @{ Operator = "`e[95m"; Parameter = "`e[95m" }

This issue is really a request for PSReadLine to support this:
PowerShell/PSReadLine#464

in other words, better "theme-ing". We can close this issue since PSReadLine should handle this and not the PowerShell extension.

@TylerLeonhardt TylerLeonhardt added Resolution-External Will close automatically. and removed Needs: Triage Maintainer attention needed! labels Apr 16, 2020
@0x57e11a
Copy link
Author

Thanks!

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Apr 16, 2020
@SydneyhSmith SydneyhSmith removed the Needs: Maintainer Attention Maintainer attention needed! label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-External Will close automatically.
Projects
None yet
Development

No branches or pull requests

5 participants