Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xWindowsFeatureSet.schema.psm1: Fix Custom DSC Resource Kit PSSA rule violations #501

Closed
mhendric opened this issue Jan 27, 2019 · 0 comments · Fixed by #567
Closed

xWindowsFeatureSet.schema.psm1: Fix Custom DSC Resource Kit PSSA rule violations #501

mhendric opened this issue Jan 27, 2019 · 0 comments · Fixed by #567
Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.

Comments

@mhendric
Copy link
Contributor

Details of the scenario you tried and the problem that is occurring

There's a number of script analyzer issues getting reported in xWindowsFeatureSet.schema.psm1. These should be fixed.

Verbose logs showing the problem

[00:05:20]     Context xWindowsFeatureSet.schema.psm1
[00:05:20]       [+] Should pass all error-level PS Script Analyzer rules 79ms
[00:05:20]       [+] Should pass all required PS Script Analyzer rules 112ms
[00:05:20]       [+] Should pass all flagged PS Script Analyzer rules 61ms
[00:05:20]       [+] Should pass any recently-added, error-level PS Script Analyzer rules 63ms
[00:05:20]       [+] Should not suppress any required PS Script Analyzer rules 116ms
[00:05:21] Custom DSC Resource Kit PSSA rule(s) did not pass.
[00:05:21] The following PSScriptAnalyzer rule 'DscResource.AnalyzerRules\Measure-ParameterBlockParameterAttribute' errors need to be fixed:
[00:05:21] xWindowsFeatureSet.schema.psm1 (Line 46): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:21] xWindowsFeatureSet.schema.psm1 (Line 50): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:21] xWindowsFeatureSet.schema.psm1 (Line 54): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:21] xWindowsFeatureSet.schema.psm1 (Line 57): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:21] xWindowsFeatureSet.schema.psm1 (Line 62): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:21] For instructions on how to run PSScriptAnalyzer on your own machine, please go to https://github.com/powershell/PSScriptAnalyzer
[00:05:21] Common Tests - Custom Script Analyzer Rules will not fail unless you opt-in.
[00:05:21] To opt-in, create a '.MetaTestOptIn.json' at the root
[00:05:21] of the repo in the following format:
[00:05:21] [
[00:05:21]      "Common Tests - Custom Script Analyzer Rules"
[00:05:21] ]
[00:05:21]       [+] Should pass all custom DSC Resource Kit PSSA rules 649ms

Version of the DSC module that was used ('dev' if using current dev branch)

dev

@mhendric mhendric added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jan 27, 2019
@mhendric mhendric changed the title xWindowsFeatureSet.schema.psm1: Fix Script Analyzer Issues xWindowsFeatureSet.schema.psm1: Fix Custom DSC Resource Kit PSSA rule violations Feb 12, 2019
@mhendric mhendric added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Projects
None yet
1 participant