Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request Template Refers to BestPractices.MD and Should Not #520

Closed
PlagueHO opened this issue Feb 3, 2019 · 2 comments · Fixed by #521
Closed

Pull Request Template Refers to BestPractices.MD and Should Not #520

PlagueHO opened this issue Feb 3, 2019 · 2 comments · Fixed by #521
Assignees
@PlagueHO
Labels
documentation The issue is related to documentation only. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Feb 3, 2019

The GitHub PR template refers to BestPractices.MD which is now part of StyleGuidelines.MD. This should be removed.
@PlagueHO PlagueHO added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. documentation The issue is related to documentation only. labels Feb 3, 2019
@PlagueHO PlagueHO self-assigned this Feb 3, 2019
@PlagueHO PlagueHO mentioned this issue Feb 3, 2019
Merged
9 tasks
@mhendric
Copy link
Contributor

mhendric commented Feb 3, 2019

Resolved in #521

@mhendric mhendric closed this as completed Feb 3, 2019
@mhendric mhendric reopened this Feb 3, 2019
@mhendric
Copy link
Contributor

mhendric commented Feb 3, 2019

Not YET resolved in #521. Re-opening.

mhendric added a commit that referenced this issue Feb 4, 2019
@mhendric
Merge pull request #521 from PlagueHO/Issue-520
ac0411a 
Correct GitHub Pull Request Template - Fixes #520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PlagueHO PlagueHO

Labels
documentation The issue is related to documentation only. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct GitHub Pull Request Template - Fixes #520 PlagueHO/xPSDesiredStateConfiguration
2 participants
@PlagueHO @mhendric