Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xPSDesiredStateConfiguration: Support for PowerShell 4 #522

Closed
mhendric opened this issue Feb 3, 2019 · 7 comments · Fixed by #550
Closed

xPSDesiredStateConfiguration: Support for PowerShell 4 #522

mhendric opened this issue Feb 3, 2019 · 7 comments · Fixed by #550
Labels
discussion The issue is a discussion.

Comments

@mhendric
Copy link
Contributor

mhendric commented Feb 3, 2019

We don't currently have any automated tests that test this module using PowerShell 4. It's also starting to look like parts of the module don't currently work with PowerShell 4 (see #511). I think we need to figure out what our stance is on PowerShell 4 going forward. Do we want to fully support it? If so, I think we need to get PowerShell 4 based test coverage on it. Do we want to drop official support for it? Do we take the stance that this MAY work with PowerShell 4, but we're not going to test it? Open to other suggestions, but wanted to at least start a discussion on the topic.

@mhendric mhendric added the discussion The issue is a discussion. label Feb 3, 2019
@PlagueHO
Copy link
Member

PlagueHO commented Feb 3, 2019

A good question. Let's bring it up at the community call. I'm assembling a list of things to bring up.

@tmeckel
Copy link
Contributor

tmeckel commented Feb 4, 2019

Normally you'd ditch this module because Powershell 4 is now so damn outdated. But I would believe there 're still many PS4 installations out there in the wild :-D

@tmeckel
Copy link
Contributor

tmeckel commented Feb 4, 2019

One addtion #511 (comment) .. We can't simply ditch xPSDesiredStateConfiguration because it conatins unique DSC Modules like MSFT_xDSCWebService.psm1

@tmeckel
Copy link
Contributor

tmeckel commented Feb 14, 2019

@mhendric , @PlagueHO so after the last community call and the explanations from @kwirkykat .. can this issue be closed now? I would prefer though, this issue is not simply closed but that some statements are added to the README.md files in the two repositories respectively that reflect the statements from Katie.

@mhendric
Copy link
Contributor Author

Yeah, I think we just need to add a formal statement at the top of the README.md on our PS4 stance, then this can be closed. Perhaps something like this. What do you all think?

This module is automatically tested using PowerShell 5.1 on servers running Windows 2012 R2 and Windows 2016, and is expected to work on other operating systems running PowerShell 5.1. While this module may work with PowerShell versions going back to PowerShell 4, there is no automatic testing performed for these versions, and thus no guarantee that the module will work as expected.

@PlagueHO
Copy link
Member

That looks pretty good @mhendric

@tmeckel
Copy link
Contributor

tmeckel commented Feb 14, 2019

Yes I agree with @PlagueHO ... sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion The issue is a discussion.
Projects
None yet
3 participants