Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerAlwaysOnService: Integration test is missing for this resource #736

Closed
johlju opened this issue Aug 13, 2017 · 0 comments · Fixed by #810
Closed

xSQLServerAlwaysOnService: Integration test is missing for this resource #736

johlju opened this issue Aug 13, 2017 · 0 comments · Fixed by #810
Assignees
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Aug 13, 2017

Details of the scenario you tried and the problem that is occurring:
We should add an integration test for this resource.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Aug 13, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Aug 13, 2017
- Added integration test (issue dsccommunity#736).
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Aug 16, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Aug 19, 2017
- Added integration test (issue dsccommunity#736).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 12, 2017
- Added integration test (issue dsccommunity#736).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 13, 2017
- Added integration test (issue dsccommunity#736).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 14, 2017
- Added integration test (issue dsccommunity#736).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 15, 2017
- Added integration test (issue dsccommunity#736).
johlju added a commit that referenced this issue Sep 15, 2017
- Changes to xSQLServer
  - Moved the code block, that contains workarounds in appveyor.yml, so it is run
    during the install phase instead of the test phase.
- Changes to xSQLServerSetup
  - Changes to integration tests.
    - Moved the configuration block from the MSFT\_xSQLServerSetup.Integration.Tests.ps1
      to the MSFT\_xSQLServerSetup.config.ps1 to align with the other integration
      test. And also get most of the configuration in one place.
    - Changed the tests so that the local SqlInstall account is added as a member
      of the local administrators group.
    - Changed the tests so that the local SqlInstall account is added as a member
      of the system administrators in SQL Server (Database Engine) - needed for the
      xSQLServerAlwaysOnService integration tests.
    - Changed so that only one of the Modules-folder for the SQLPS PowerShell module
      for SQL Server 2016 is renamed back so it can be used with the integration
      tests. There was an issue when more than one SQLPS module was present (see
      more information in issue #806).
- Changes to xSQLServerAlwaysOnService
  - Added integration test (issue #736).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant